drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 2517: Apply directory-based partition pr...
Date Mon, 25 Jan 2016 06:12:26 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/328#discussion_r50656611
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
    @@ -82,11 +101,19 @@ public int getMaxHierarchyLevel() {
         return MAX_NESTED_SUBDIRS;
       }
     
    -  @Override
    -  public GroupScan createNewGroupScan(List<String> newFiles) throws IOException
{
    -    final FileSelection newSelection = FileSelection.create(null, newFiles, getBaseTableLocation());
    -    final FileGroupScan newScan = ((FileGroupScan)scanRel.getGroupScan()).clone(newSelection);
    -    return newScan;
    +//  @Override
    +//  public GroupScan createNewGroupScan(List<String> newFiles) throws IOException
{
    --- End diff --
    
    This function can be removed completely...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message