drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #597: DRILL-4905: Push down the LIMIT to the parquet read...
Date Tue, 27 Sep 2016 23:24:04 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/597#discussion_r80817027
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -115,6 +115,8 @@
       private List<RowGroupInfo> rowGroupInfos;
       private Metadata.ParquetTableMetadataBase parquetTableMetadata = null;
       private String cacheFileRoot = null;
    +  private int batchSize;
    +  private static final int DEFAULT_BATCH_LENGTH = 256 * 1024;
    --- End diff --
    
    Max value for store.parquet.record_batch_size is 256K. So, it cannot be set to 512K. I
changed the name in ParquetGroupScan/ParquetRowGroupScan to recommendedBatchSize as we discussed.
Please review new diffs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message