drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitblender <...@git.apache.org>
Subject [GitHub] drill pull request #697: DRILL-5097: Using store.parquet.reader.int96_as_tim...
Date Mon, 02 Jan 2017 23:47:21 GMT
Github user bitblender commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
    @@ -110,9 +110,14 @@ protected void readField(long recordsToReadInThisPass) {
        * Class for reading parquet fixed binary type INT96, which is used for storing hive,
    -   * impala timestamp values with nanoseconds precision. So it reads such values as a
drill timestamp.
    +   * impala timestamp values with nanoseconds precision (12 bytes). So it reads such
values as a drill timestamp (8 bytes).
       static class NullableFixedBinaryAsTimeStampReader extends NullableFixedByteAlignedReader<NullableTimeStampVector>
    +    /**
    +     * The width of each element of the TimeStampVector is 8 byte(s).
    +     */
    +    private static final int timestampLengthInBits = 64;
    --- End diff --
    I would recommend the use of uppercase in naming constants.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message