drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Thu, 05 Jan 2017 02:33:58 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java
    @@ -89,11 +94,16 @@ public Writer getWriter(PhysicalOperator child) throws IOException
    -    return formatPlugin.getWriter(child, location, partitionColumns);
    +    AbstractWriter writer = formatPlugin.getWriter(child, location, partitionColumns);
    +    if (storageStrategy != null) {
    +      writer.setStorageStrategy(storageStrategy);
    --- End diff --
    Can the `setStorageStrategy` method accept a null storage strategy? Substitute `PERSISTENT`
for null? Doing so will save the != null checks here and anywhere else that the method is

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message