drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Thu, 05 Jan 2017 03:48:15 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r94697483
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/QueryClassLoader.java
---
    @@ -58,6 +58,19 @@ public void injectByteCode(String className, byte[] classBytes) throws
IOExcepti
           throw new IOException(String.format("The class defined %s has already been loaded.",
className));
         }
         customClasses.put(className, classBytes);
    +
    --- End diff --
    
    Maybe add a comment that for the "before manipulations BC" see ClassCompilerSelector.java
(line 122) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message