drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Thu, 05 Jan 2017 21:52:41 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r94859288
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java ---
    @@ -164,6 +164,8 @@ public void operationComplete(ChannelFuture future) throws Exception
{
           }
     
           final ChannelClosedException ex = future.cause() != null ? new ChannelClosedException(msg,
future.cause()) : new ChannelClosedException(msg);
    +      // close client connection to drop all temporary tables
    +      clientConnection.close();
    --- End diff --
    
    Here we assume that the `close()` won't throw an exception. Clearly, it throws no checked
exceptions. But, Drill likes to throw unchecked exceptions. Do we need to worry about that
here? Even if such an exception were to occur; we'd still want to close the channel below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message