drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Thu, 05 Jan 2017 21:52:42 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r94858741
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
    @@ -382,4 +391,20 @@ public void cleanup() throws IOException {
     
         codecFactory.release();
       }
    +
    +  /**
    +   * Prepares location where files will be written to.
    +   * Creates directory if not present, applies storage strategy.
    +   *
    +   * @return path to files location
    +   * @throws IOException during directory creation or permission setting problems
    +   */
    +  private Path prepareLocationPath() throws IOException {
    +    if (locationPath == null) {
    +      locationPath = new Path(location);
    +      fs.mkdirs(locationPath);
    --- End diff --
    
    See note above about question about setting permissions on each newly created folder in
the path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message