drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #716: DRILL-5116: Enable generated code debugging in each...
Date Thu, 05 Jan 2017 23:34:44 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/716#discussion_r94875353
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java
---
    @@ -117,18 +200,24 @@ public CodeCompiler(final DrillConfig config, final OptionManager
optionManager)
       private class Loader extends CacheLoader<CodeGenerator<?>, GeneratedClassEntry>
{
         @Override
         public GeneratedClassEntry load(final CodeGenerator<?> cg) throws Exception
{
    -      final Class<?> c;
    -      if ( cg.isPlainOldJava( ) ) {
    -        // Generate class as plain old Java
    +      return makeClass(cg);
    +    }
    +  }
     
    -        c = classBuilder.getImplementationClass(cg);
    -      } else {
    -        // Generate class parts and assemble byte-codes.
    +  /**
    +   * Called when the requested class does not exist in the class and should
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message