drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Fri, 06 Jan 2017 01:33:34 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r94866946
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptionsAuthEnabled.java
---
    @@ -17,7 +17,10 @@
      */
     package org.apache.drill.exec.server;
     
    +import com.google.common.collect.Lists;
    +import com.typesafe.config.ConfigValueFactory;
     import org.apache.drill.BaseTestQuery;
    +import org.apache.drill.common.config.ConnectionParameters;
     import org.apache.drill.common.config.DrillConfig;
    --- End diff --
    
    It would be great to add negative. Some of which I can think of are as below. Not sure
if they are already covered.
    1) Server not configured for any mechanism.
    2) Server configured for mechanism but client requesting some other mechanism for authentication
    3) Client getting service ticket for one host but sending message to different host.
    4) Client trying to authenticate with kdc using wrong creds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message