drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Date Wed, 11 Jan 2017 23:02:51 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95692761
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -106,6 +106,7 @@
       <p>STATE: ${model.getProfile().getState().name()}</p>
       <p>FOREMAN: ${model.getProfile().getForeman().getAddress()}</p>
       <p>TOTAL FRAGMENTS: ${model.getProfile().getTotalFragments()}</p>
    +  <p>DURATION: ${model.getProfileDuration()}</p>
    --- End diff --
    
    The end time for a query is not set until the very end of the query, so the default value
in 0L. For the `/profiles ` template, the elapsed time is computed using the current time
in millis for running queries. Hence it shows correctly here. As per your suggestion, fixed
it now by changing the signature to take the start and end times as arguments.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message