drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #702: DRILL-5088: set default codec for toJson
Date Thu, 12 Jan 2017 03:21:42 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/702#discussion_r95719700
  
    --- Diff: contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
---
    @@ -503,7 +505,9 @@ public ScanStats getScanStats() {
           long numDocs = collection.count();
           float approxDiskCost = 0;
           if (numDocs != 0) {
    -        String json = collection.find().first().toJson();
    +        final DocumentCodec codec =
    --- End diff --
    
    Please add a comment to describe the need for the codec along with the example from the
bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message