drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #714: DRILL-4919: Fix select count(1) / count(*) on csv w...
Date Thu, 12 Jan 2017 03:42:53 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/714#discussion_r95721099
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
---
    @@ -91,6 +96,9 @@ public boolean apply(@Nullable SchemaPath path) {
     
       @Override
       protected List<SchemaPath> getDefaultColumnsToRead() {
    +    if (settings.isHeaderExtractionEnabled()) {
    --- End diff --
    
    Please add a comment describing the change - something similar to your comment 
    > ... currently text files with headers do not support columns syntax, so for these
type of files we need to replace empty list of columns with default named column when header
extraction is enabled


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message