drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #581: DRILL-4864: Add ANSI format for date/time functions
Date Thu, 12 Jan 2017 21:28:19 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
    @@ -0,0 +1,176 @@
    +* Licensed to the Apache Software Foundation (ASF) under one or more
    +* contributor license agreements.  See the NOTICE file distributed with
    +* this work for additional information regarding copyright ownership.
    +* The ASF licenses this file to you under the Apache License, Version 2.0
    +* (the "License"); you may not use this file except in compliance with
    +* the License.  You may obtain a copy of the License at
    +* http://www.apache.org/licenses/LICENSE-2.0
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +package org.apache.drill.common.expression.fn;
    +import org.joda.time.DateTime;
    +import org.joda.time.DateTimeZone;
    +import org.joda.time.format.DateTimeFormatter;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import static org.apache.drill.common.expression.fn.JodaDateValidator.toJodaFormat;
    +import static org.joda.time.DateTime.parse;
    +import static org.joda.time.format.DateTimeFormat.forPattern;
    +public class JodaDateValidatorTest {
    --- End diff --
    Was rather expecting many more tests. Might be easier to structure them as an array of
(input, expected) values so that the cost of adding more tests is low. See discussion above
about the kinds of tests expected: each and every format and variation, including ambiguous

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message