drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #696: DRILL-4558: BSonReader should prepare buffer size a...
Date Fri, 13 Jan 2017 18:46:20 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/696#discussion_r96048977
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
---
    @@ -103,6 +103,17 @@ public void testStringType() throws IOException {
       }
     
       @Test
    +  public void testSpecialCharStringType() throws IOException {
    +    BsonDocument bsonDoc = new BsonDocument();
    +    bsonDoc.append("stringKey", new BsonString("§§§§§§§§§1"));
    --- End diff --
    
    Might want to put your value in a string, convert to byte but, and assert that the byte
buf length differs in length from the string length. This will verify that this test is, in
fact, testing the problem case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message