drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nagarajanchinnasamy <...@git.apache.org>
Subject [GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...
Date Mon, 16 Jan 2017 07:37:28 GMT
Github user nagarajanchinnasamy commented on the issue:

    https://github.com/apache/drill/pull/685
  
    @arina-ielchiieva @sudheeshkatkam I have made the following changes to support invocation
of UDFs without parenthesis.
    
    1. Introduced `isNiladic` option in FunctionTemplate and added a property in DrillFuncHolder,
FunctionAttributes, DrillSqlOperator classes
    
    2. Overridden DrillSqlOperator.getSyntax() to return SqlSyntax.FUNCTION_ID when isNiladic
is true
    
    3. Modified all the places to pass false for isNiladic parameter to DrillSqlOperator constructor
-- so that existing behavior is not impacted
    
    4. In DrillOperatorTable, adding an operator to operatorList when the syntax of an operator
is either FUNCTION or FUNCTION_ID
    
    5. Modified tests to invoke session_id without parenthesis. 
    
    Please review the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message