drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #697: DRILL-5097: Using store.parquet.reader.int96_as_tim...
Date Mon, 16 Jan 2017 13:09:43 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/697#discussion_r96213729
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java
---
    @@ -132,6 +137,9 @@ protected void readField(long recordsToReadInThisPass) {
               valueVec.getMutator().setSafe(valuesReadInCurrentPass + i, getDateTimeValueFromBinary(binaryTimeStampValue));
             }
           }
    +      // The nanos precision is cut to millis. Therefore the length of single timestamp
value is 8 bytes(s)
    +      // instead of 12 byte(s).
    +      dataTypeLengthInBits = timestampLengthInBits;
    --- End diff --
    
    Yes, it is. Because when [`PARQUET_READER_INT96_AS_TIMESTAMP` is set to false](
    https://github.com/apache/drill/blob/83513daf0903e0d94fcaad7b1ae4e8ad6272b494/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java#L246)

    `NullableFixedBinaryAsTimeStampReader` will not used. Instead of that `NullableFixedBinaryReader`
will used.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message