drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort
Date Thu, 02 Feb 2017 22:44:51 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/717#discussion_r99037413
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -63,13 +63,29 @@
       String SPOOLING_BUFFER_DELETE = "drill.exec.buffer.spooling.delete";
       String SPOOLING_BUFFER_MEMORY = "drill.exec.buffer.spooling.size";
       String BATCH_PURGE_THRESHOLD = "drill.exec.sort.purge.threshold";
    +
    +  // External Sort Boot configuration
    +
       String EXTERNAL_SORT_TARGET_BATCH_SIZE = "drill.exec.sort.external.batch.size";
       String EXTERNAL_SORT_TARGET_SPILL_BATCH_SIZE = "drill.exec.sort.external.spill.batch.size";
       String EXTERNAL_SORT_SPILL_GROUP_SIZE = "drill.exec.sort.external.spill.group.size";
       String EXTERNAL_SORT_SPILL_THRESHOLD = "drill.exec.sort.external.spill.threshold";
       String EXTERNAL_SORT_SPILL_DIRS = "drill.exec.sort.external.spill.directories";
       String EXTERNAL_SORT_SPILL_FILESYSTEM = "drill.exec.sort.external.spill.fs";
    +  String EXTERNAL_SORT_SPILL_FILE_SIZE = "drill.exec.sort.external.spill.file_size";
       String EXTERNAL_SORT_MSORT_MAX_BATCHSIZE = "drill.exec.sort.external.msort.batch.maxsize";
    +  String EXTERNAL_SORT_DISABLE_MANAGED = "drill.exec.sort.external.disable_managed";
    +  String EXTERNAL_SORT_MERGE_LIMIT = "drill.exec.sort.external.merge_limit";
    +  String EXTERNAL_SORT_MIN_SPILL = "drill.exec.sort.external.spill.min_batches";
    +  String EXTERNAL_SORT_MAX_SPILL = "drill.exec.sort.external.spill.max_batches";
    +  String EXTERNAL_SORT_MAX_MEMORY = "drill.exec.sort.external.mem_limit";
    +  String EXTERNAL_SORT_BATCH_LIMIT = "drill.exec.sort.external.batch_limit";
    +
    +  // External Sort Runtime options
    +
    +  BooleanValidator EXTERNAL_SORT_DISABLE_MANAGED_OPTION = new BooleanValidator("exec.sort.disable_managed",
false);
    --- End diff --
    
    True. In the 1.10 release, this will change to "true". But, to prevent instability in
this initial checkin, the old sort is left as the default. Of course, this PR has taken a
while, so the new PR to set this to "true" may come only a few days after this PR is finally
accepted...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message