drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #746: DRILL-5254: Enhance default reduction factors in op...
Date Tue, 14 Feb 2017 19:12:59 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/746#discussion_r101117331
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -91,7 +91,22 @@ drill.exec: {
         use.ip : false
       },
       optimizer: {
    -    implementation: "org.apache.drill.exec.opt.IdentityOptimizer"
    +    implementation: "org.apache.drill.exec.opt.IdentityOptimizer",
    +    enhanced_defaults: {
    --- End diff --
    
    Any particular reason why you make this option as boot-time option, in stead of system
option? Majority planner options, if not all, are able to reset either at system or session
level. That will give the user option for better control.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message