drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...
Date Thu, 16 Feb 2017 20:56:33 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r101624385
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -492,7 +538,19 @@ private void writeDataAllText(MapWriter map, FieldSelection selection,
           }
         }
         map.end();
    +  }
     
    +  /**
    +   * Puts copy of field path list to fieldPathWriter map.
    +   * @param fieldName
    +   */
    +  private void putFieldPath(String fieldName, MapWriter map) {
    --- End diff --
    
    Do you have the performance data that you had collected earlier with different percentage
of NULLs, after this change ?  I still feel there could be some further optimization needed.
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message