drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #748: DRILL-5263: Prevent left NLJoin with non scalar sub...
Date Thu, 16 Feb 2017 21:35:45 GMT
Github user amansinha100 commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java
    @@ -49,7 +49,7 @@ protected boolean checkPreconditions(DrillJoinRel join, RelNode left,
RelNode ri
           PlannerSettings settings) {
         JoinRelType type = join.getJoinType();
    -    if (! (type == JoinRelType.INNER || type == JoinRelType.LEFT)) {
    +    if (!(type == JoinRelType.INNER || (type == JoinRelType.LEFT && JoinUtils.hasScalarSubqueryInput(left,
right)))) {
    --- End diff --
    @Serhii-Harnyk were you able to confirm what @zfong asked about w.r.t correctness ? The
code is still allowing left nested join with scalar subquery, so it seems her comment is still

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message