drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #751: DRILL-5259: Allow listing a user-defined number of ...
Date Fri, 17 Feb 2017 22:42:10 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/751#discussion_r101862127
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
    @@ -190,10 +193,13 @@ public QProfiles(List<ProfileInfo> runningQueries, List<ProfileInfo>
finishedQue
         public List<String> getErrors() { return errors; }
       }
     
    +  //max Param to cap listing of profiles 
    +  private static final String MAX_QPARAM = "max";
    +
    --- End diff --
    
    please choose a better name than MAX_QPARAM something like MAX_QPROFILES_PARAM  ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message