drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #751: DRILL-5259: Allow listing a user-defined number of ...
Date Sun, 19 Feb 2017 06:59:51 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/751#discussion_r101910265
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
    @@ -190,10 +192,13 @@ public QProfiles(List<ProfileInfo> runningQueries, List<ProfileInfo>
finishedQue
         public List<String> getErrors() { return errors; }
       }
     
    +  //max Param to cap listing of profiles
    +  private static final String MAX_QPROFILES_PARAM = "max";
    --- End diff --
    
    It's just a convenient variable name for now, since it preserves the constant originally
there `MAX_PROFILES`
    The patch came as a result of this [exchange](https://www.mail-archive.com/user@drill.apache.org/msg05992.html)
on drill-user list, so I didn't changing it for the patch. If we use pagination, perhaps then
we can. 
    For now, someone in the community has proposed this, which takes this further ahead: [DRILL-5068](https://issues.apache.org/jira/browse/DRILL-5068)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message