drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #746: Drill 5254: Enhance default reduction factors in op...
Date Sun, 12 Feb 2017 23:34:01 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/746

    Drill 5254: Enhance default reduction factors in optimizer

    Provides enhanced default selectivity rules as defined in DRILL-5254. Please see the JIRA
entry for the details.
    
    The rules are selectable with a boot-time option and are disabled by default to allow
full testing of the rules before they become enabled by default.
    
    Also provides a complete unit test. The test required enhancements to the new test framework;
those enhancements are also included.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #746
    
----
commit 62edc37fcb4034fed6f502b34e20923b7b6e5e75
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-02-12T23:25:02Z

    Feature implementation
    
    Provides enhanced default selectivity rules as defined in DRILL-5254.
    The rules are selectable with a boot-time option and are disabled by
    default to allow full testing of the rules before they become enabled
    for all.

commit 66c59a2fc535e668599bb40765074ee7d6000aa9
Author: Paul Rogers <progers@maprtech.com>
Date:   2017-02-12T23:31:37Z

    Unit tests and supporting code
    
    Provides unit tests for the feature.
    
    Required adding a boolean field type to the mock data source.
    
    This test relies on saving query profiles and analyzing them to detect
    selectivity. However, the CTTAS feature introduced a check that causes
    tests to fail if they save query profiles for analysis. Provides a
    workaround in the test framework to delete the locally stored files
    before each test that will preserve local state.
    
    Added comments to several test methods.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message