drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #822: DRILL-5457: Spill implementation for Hash Aggregate
Date Thu, 01 Jun 2017 22:57:33 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r119749313
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -323,38 +717,32 @@ public AggOutcome doWork() {
                     if (EXTRA_DEBUG_1) {
                       logger.debug("Received new schema.  Batch has {} records.", incoming.getRecordCount());
                     }
    -//                newSchema = true;
                     this.cleanup();
                     // TODO: new schema case needs to be handled appropriately
                     return AggOutcome.UPDATE_AGGREGATOR;
     
                   case OK:
                     resetIndex();
    -                if (incoming.getRecordCount() == 0) {
    -                  continue;
    -                } else {
    -                  checkGroupAndAggrValues(currentIndex);
    -                  incIndex();
    -
    -                  if (EXTRA_DEBUG_1) {
    -                    logger.debug("Continuing outside loop");
    -                  }
    -                  continue outside;
    +
    +                if (EXTRA_DEBUG_1) {
    +                  logger.debug("Continuing outside loop");
                     }
    +                continue outside;
     
                   case NONE:
    -                // outcome = out;
    +                underlyingIndex = 0; // in case need to handle a spilled partition
    +                try { currentIndex = getVectorIndex(underlyingIndex); }
    +                catch (SchemaChangeException sc) { throw new DrillRuntimeException(sc);}
    --- End diff --
    
    Done -- all SCE catchers either call UnsupportedOperationException, or (when clearly not
possible then) IllegalStateException 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message