drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #847: Drill 5545: Update POM to add support for running f...
Date Sat, 03 Jun 2017 19:20:24 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/847#discussion_r119979144
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
    @@ -105,22 +105,34 @@ protected void loadDictionaryIfExists(final ColumnReader<?>
parentStatus,
         if (columnChunkMetaData.getDictionaryPageOffset() > 0) {
           try {
             assert(columnChunkMetaData.getDictionaryPageOffset() >= dataReader.getPos()
);
    -        dataReader.skip(columnChunkMetaData.getDictionaryPageOffset() - dataReader.getPos());
    +        long bytesToSkip = columnChunkMetaData.getDictionaryPageOffset() - dataReader.getPos();
    +        while (bytesToSkip > 0) {
    +          long skipped = dataReader.skip(bytesToSkip);
    +          if (skipped > 0) {
    +            bytesToSkip -= skipped;
    +          } else {
    +            // no good way to handle this. Guava uses InputStream.available to check
    +            // if EOF is reached and because available is not reliable,
    +            // tries to read the rest of the data.
    +            DrillBuf skipBuf = dataReader.getNext((int) bytesToSkip);
    +            if (skipBuf != null) {
    +              skipBuf.release();
    +            } else {
    +              throw new EOFException("End of File reachecd.");
    --- End diff --
    
    Typo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message