drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #808: DRILL-5325: Unit tests for the managed sort
Date Tue, 06 Jun 2017 22:40:46 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/BaseAllocator.java
    @@ -793,20 +797,20 @@ public static boolean isDebug() {
         return DEBUG;
    -  /**
    -   * Disk I/O buffer used for all reads and writes of DrillBufs.
    -   */
    -  private byte ioBuffer[];
       public byte[] getIOBuffer() {
         if (ioBuffer == null) {
    +      // Length chosen to the smallest size that maximizes
    +      // disk I/O performance. Smaller sizes slow I/O. Larger
    +      // sizes provide no increase in performance.
    +      // Revisit from time to time.
    --- End diff --
    Fixed. It is a constant because no one can detect changes to performance of the number
from outside Drill. To come up with the number required intense, focused tests.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message