drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Wed, 21 Jun 2017 16:19:00 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123293533
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -204,7 +276,7 @@ public boolean isClosed() {
     
       @Override
       public int getMaxFieldSize() throws SQLException {
    -    throwIfClosed();
    +    throwIfTimedOutOrClosed();
    --- End diff --
    
    this methods cannot throw SqlTimeoutException... only `execute*` methods can, and eventually
some ResultSet methods (but this part is optional per JDBC standard)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message