drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #853: DRILL-5130: Fix explainTerms method for Values node...
Date Wed, 21 Jun 2017 17:21:25 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/853#discussion_r123312311
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillValuesRelBase.java
---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner.common;
    +
    +import org.apache.calcite.plan.RelOptCluster;
    +import org.apache.calcite.plan.RelTraitSet;
    +import org.apache.calcite.rel.AbstractRelNode;
    +import org.apache.calcite.rel.RelWriter;
    +import org.apache.calcite.rel.type.RelDataType;
    +import org.apache.drill.common.JSONOptions;
    +
    +/**
    + * Base class for logical and physical Values implemented in Drill.
    + */
    +public abstract class DrillValuesRelBase extends AbstractRelNode {
    --- End diff --
    
    Calcite has an abstract class Values. Neither of DrillValueRel or ValuePrel extends from
that Calcite class. Will it help solve the problem if we extend from Calcite's class?
    
    https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/core/Values.java



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message