drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Wed, 21 Jun 2017 18:08:02 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123324366
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
    @@ -64,13 +65,17 @@
           org.slf4j.LoggerFactory.getLogger(DrillResultSetImpl.class);
     
       private final DrillConnectionImpl connection;
    +  private DrillStatementImpl drillStatement = null;
       private volatile boolean hasPendingCancelationNotification = false;
     
       DrillResultSetImpl(AvaticaStatement statement, Meta.Signature signature,
                          ResultSetMetaData resultSetMetaData, TimeZone timeZone,
                          Meta.Frame firstFrame) {
         super(statement, signature, resultSetMetaData, timeZone, firstFrame);
         connection = (DrillConnectionImpl) statement.getConnection();
    +    if (statement instanceof DrillStatementImpl) {
    --- End diff --
    
    The original DrillStatement threw an exception for setting the query time out, but I don't
see the same for the DrillPreparedStatement, which tries to call Avatica's implementation.
My testing indicates that this is effectively a No-Op. I can extend it to that as well, but
I was hoping to hear back from you first. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message