drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Wed, 21 Jun 2017 18:29:43 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123329889
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -159,24 +230,25 @@ public void cleanUp() {
       public int getQueryTimeout() throws AlreadyClosedSqlException
       {
         throwIfClosed();
    -    return 0;  // (No no timeout.)
    --- End diff --
    
    it's an optional thing, but the spec doesn't say what happens if you set it but it's actually
not used...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message