drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #851: DRILL-5518: Test framework enhancements
Date Wed, 21 Jun 2017 23:42:14 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/RowSetTest.java
    @@ -309,13 +317,38 @@ private void testDoubleRW() {
         assertEquals(0, reader.column(0).getDouble(), 0.000001);
         assertEquals(Double.MAX_VALUE, reader.column(0).getDouble(), 0.000001);
    +    assertEquals(Double.MAX_VALUE, (double) reader.column(0).getObject(), 0.000001);
    --- End diff --
    Casting is required because `assertEquals` does not know what to do with an `Object` as
its second argument. The cast to `double` forces a cast to `Double`, then unboxing.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message