drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #844: DRILL-5538: Create TopProject with validatedNodeTyp...
Date Thu, 22 Jun 2017 22:01:50 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/TopProjectVisitor.java
    @@ -0,0 +1,139 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner.physical.visitor;
    +import org.apache.calcite.rel.RelNode;
    +import org.apache.calcite.rel.core.Project;
    +import org.apache.calcite.rel.type.RelDataType;
    +import org.apache.calcite.rex.RexBuilder;
    +import org.apache.calcite.rex.RexNode;
    +import org.apache.calcite.rex.RexUtil;
    +import org.apache.calcite.sql.validate.SqlValidatorUtil;
    +import org.apache.drill.exec.planner.common.DrillRelOptUtil;
    +import org.apache.drill.exec.planner.physical.Prel;
    +import org.apache.drill.exec.planner.physical.ProjectPrel;
    +import org.apache.drill.exec.planner.physical.ScreenPrel;
    +import org.apache.drill.exec.planner.physical.WriterPrel;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    + * Adds non-trivial top project to ensure the final output field names are preserved.
    + * Is added under the screen or writer operators.
    --- End diff --
    You may add comments why we need such non-trivial project, due to Calcite's behavior of
ProjectRemoveRule. Also, it might be worth mentioning that the added Project may not be sitting
right under Screen/Writer operator in the physical plan, as we would add additional Projects,
for case likes * column expansion, or partition by column processing.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message