drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #858: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Date Sat, 24 Jun 2017 00:29:06 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123865256
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
    @@ -125,7 +154,7 @@ protected void cancel() {
       // (Not delegated.)
       @Override
       public boolean next() throws SQLException {
    -    throwIfClosed();
    +    throwIfTimedOutOrClosed();
    --- End diff --
    
    Tested this out with the latest commit and I'm able to successfully interrupt the next()
as well. Occasionally, the exceptions get missed, so we do a check down to the DrillResultSet
and not the DrillCursor as I'm trying to restrict the timeout check only to the JDBC layers
and not too close to the DrillClient. Testcases verify by executing and then sleeping till
the duration of the timeout before invoking the next() method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message