drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Date Wed, 28 Jun 2017 21:19:16 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/862#discussion_r124659309
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
    @@ -409,9 +414,10 @@ public Void call() throws IOException {
     
           DrillBuf pageData = null;
           timer.reset();
    -      try {
    +      parqProcessing: try {
    --- End diff --
    
    Maybe just check isShuttingDown here and return? (breaks with labels with no outer for/while
loops confuse me!) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message