drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Date Thu, 29 Jun 2017 00:29:01 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/862#discussion_r124688876
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
    @@ -409,9 +414,10 @@ public Void call() throws IOException {
     
           DrillBuf pageData = null;
           timer.reset();
    -      try {
    +      parqProcessing: try {
    --- End diff --
    
    Good point. I didn't realize that the `finally` block is empty. If there was something
to be done, a labelled break would allow the finally to be executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message