drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #840: DRILL-5517: Size-aware set methods in value vectors
Date Thu, 29 Jun 2017 15:48:16 GMT
Github user amansinha100 commented on a diff in the pull request:

    --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java ---
    @@ -674,6 +764,14 @@ public void reset(){
           setCount = 0;
           <#if type.major = "VarLen">lastSet = -1;</#if>
    +    @Override
    +    public void exchange(ValueVector.Mutator other) {
    --- End diff --
    How does swapping the value count exchange the buffer ?  The name 'exchange' indicates
more than what this method is doing.  The JIRA description says the 'exchange is for vectors
within a single operator'  but I am not sure how that is enforced considering the ValueVector.Mutator
that is passed in could belong to any ValueVector.  So, essentially we are trusting the caller
to use it only for specific cases. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message