drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …
Date Mon, 03 Sep 2018 14:47:05 GMT
vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds
exception to UserException with …
URL: https://github.com/apache/drill/pull/1455#discussion_r214651648
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileRecordReader.java
 ##########
 @@ -148,7 +148,7 @@ public int next() {
       return recordCount;
     } catch (IOException ioe) {
       close();
-      throw UserException.dataReadError(ioe).addContext("File Path", split.getPath().toString()).build(logger);
+      throw createDataReadException(ioe, null);
 
 Review comment:
   Looks like we will never get position value, so message will not be improved.
   Does it make sense to close reader after creating Data Read Exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message