drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1454: DRILL-6684: Swap sys.options and sys.options_val tables
Date Tue, 04 Sep 2018 17:36:44 GMT
arina-ielchiieva commented on a change in pull request #1454: DRILL-6684: Swap sys.options
and sys.options_val tables
URL: https://github.com/apache/drill/pull/1454#discussion_r215002783
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemTable.java
 ##########
 @@ -31,28 +31,30 @@
  * </p>
  */
 public enum SystemTable {
-  OPTION("options", false, OptionValueWrapper.class) {
+  OPTION_OLD("options_old", false, OptionValueWrapper.class) {
 
 Review comment:
   Maybe rename as `OPTIONS_OLD` and `OPTIONS` for consistency? (making it plural).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message