drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not works with national characters
Date Wed, 05 Sep 2018 00:18:15 GMT
Ben-Zvi commented on issue #1450: DRILL-6717: lower and upper functions not works with national
characters
URL: https://github.com/apache/drill/pull/1450#issuecomment-418558342
 
 
   @arina-ielchiieva - I'm still undecided; the Java technology is mature enough to handle
national characters Up/Down case conversions, so why should we reimplement and add complexity
?  Any benefit to the PR code (over using _toUpperCase()_ , etc) ?
      I compared the performance (by adding Stopwatch calls around the conversions) by converting
the same string in a loop -- the PR code initially performs poorly, then becomes on par with
the _toUpperCase()_ code (likely the JIT improves). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message