drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1460: DRILL-6732: Queries are runnable on disable plugins
Date Mon, 10 Sep 2018 13:19:16 GMT
arina-ielchiieva commented on a change in pull request #1460: DRILL-6732: Queries are runnable
on disable plugins
URL: https://github.com/apache/drill/pull/1460#discussion_r216317897
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngineConfig.java
 ##########
 @@ -34,6 +34,7 @@
   @JsonCreator
   public MockStorageEngineConfig(@JsonProperty("url") String url) {
     this.url = url;
+    this.setEnabled(true);
 
 Review comment:
   This is not correct place to enable plugin config. You enable plugin after its creation,
not directly in config itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message