drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1460: DRILL-6732: Queries are runnable on disable plugins
Date Tue, 11 Sep 2018 10:28:15 GMT
arina-ielchiieva commented on a change in pull request #1460: DRILL-6732: Queries are runnable
on disable plugins
URL: https://github.com/apache/drill/pull/1460#discussion_r216620274
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java
 ##########
 @@ -78,7 +78,7 @@ public void loadSchemaFactory(String schemaName, boolean caseSensitive)
{
     try {
       SchemaPlus schemaPlus = this.plus();
       StoragePlugin plugin = getSchemaFactories().getPlugin(schemaName);
-      if (plugin != null) {
+      if (plugin != null && plugin.getConfig().isEnabled()) {
 
 Review comment:
   Well, generally I would say the exception describes what actually is. Schema is not valid,
it means it does not exist or disabled. I am not sure we should change anything. Plus unclear
where to throw it. Definitely not in this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message