drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Ben-Zvi commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.
Date Wed, 12 Sep 2018 02:16:13 GMT
Ben-Zvi commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic
from HashJoin and HashAgg.
URL: https://github.com/apache/drill/pull/1465#discussion_r216845886
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ##########
 @@ -1026,18 +1065,6 @@ private void spillAPartition(int part) {
       /* int i = 0; */
 
 Review comment:
   Can remove this comment line as well:   `/* int i = 0; */` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message