drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Ben-Zvi commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic from HashJoin and HashAgg.
Date Wed, 12 Sep 2018 02:16:13 GMT
Ben-Zvi commented on a change in pull request #1465: DRILL-6719: Separate spilling queue logic
from HashJoin and HashAgg.
URL: https://github.com/apache/drill/pull/1465#discussion_r216878573
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ##########
 @@ -178,6 +168,58 @@
   private OperatorStats stats = null;
   private HashTableStats htStats = new HashTableStats();
 
+  public static class HashAggSpilledPartition extends AbstractSpilledPartitionMetadata {
+    private final int spilledBatches;
+    private final String spillFile;
+
+    public HashAggSpilledPartition(final int cycle,
+                                   final int originPartition,
+                                   final int prevOriginPartition,
+                                   final int spilledBatches,
+                                   final String spillFile) {
+      super(cycle, originPartition, prevOriginPartition);
+
+      this.spilledBatches = spilledBatches;
+      this.spillFile = Preconditions.checkNotNull(spillFile);
+    }
+
+    public int getSpilledBatches() {
+      return spilledBatches;
+    }
+
+    public String getSpillFile() {
+      return spillFile;
+    }
+
+    @Override
+    public String makeDebugString() {
 
 Review comment:
   Why for HashAgg this method returns **null** and not a detailed string like Hash-Join ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message