drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chunhui-shi commented on a change in pull request #1466: DRILL-6381: Add support for index based planning and execution
Date Wed, 26 Sep 2018 08:12:34 GMT
chunhui-shi commented on a change in pull request #1466: DRILL-6381: Add support for index
based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r220464735
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/JoinControl.java
 ##########
 @@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.common;
+
+/**
+ * For the int type control,
+ * the meaning of each bit start from lowest:
+ * bit 0: intersect or not, 0 -- default(no intersect), 1 -- INTERSECT (DISTINCT as default)
+ * bit 1: intersect type, 0 -- default (DISTINCT), 1 -- INTERSECT_ALL
+ */
+public class JoinControl {
 
 Review comment:
   JoinControl has to be used in HashJoin runtime operator, basically it is to allow the operator
to skip some operations when it is index join(so we are expecting INTERSECT and nothing else).
I don't have the original code at hand, but I think it should be in the first MapR 6.0 release.
Since this part is only about performance and correctness won't be impacted, if it was lost
during some merge process people might not notice it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message