drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values
Date Wed, 26 Sep 2018 08:52:10 GMT
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL functions with
constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-424637766
 
 
   @lushuifeng, thanks, looks great!
   
   But could you please also provide results for JDK and Janino compilers with and without
this feature.
   And it would be good to know the results for other literals, except strings and more complex
queries.
   
   Are there any cases, where this feature breaks something, or cause performance degradation?
If no, then no need to provide the option for disabling this functionality.
   
   Regarding unit tests, it may be written considering compiler limitation for method size
- somehow may be passed huge string literals, so query should fail without these changes.
This test should be sufficient.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message