drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution
Date Wed, 26 Sep 2018 13:05:14 GMT
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to
logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r220527920
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
 ##########
 @@ -322,13 +327,16 @@ public IterOutcome next() {
       }
 
       return batchState;
-    }
-    catch (RuntimeException | Error e) {
+    } catch (RuntimeException | Error e) {
+      failed = true;
       exceptionState = e;
       logger.trace("[#{}, on {}]: incoming next() exception: ({} ->) {}",
                    instNum, batchTypeName, prevBatchState, exceptionState,
                    exceptionState);
       throw e;
+    } catch (Exception e) {
 
 Review comment:
   Since RuntimeExceptions and Errors are already handled and compiler doesn't show any checked
Exceptions, what kind of Exceptions could be here? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message