drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution
Date Wed, 26 Sep 2018 13:05:14 GMT
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator context to
logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r220538028
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/exceptions/UserExceptionContext.java
 ##########
 @@ -133,17 +135,25 @@ String getErrorId() {
    * generate a context message
    * @return string containing all context information concatenated
    */
-  String generateContextMessage(boolean includeErrorIdAndIdentity) {
+  String generateContextMessage(boolean includeErrorIdAndIdentity, boolean includeSeeLogsMessage)
{
     StringBuilder sb = new StringBuilder();
 
     for (String context : contextList) {
-      sb.append(context).append("\n");
+      sb.append(context).append(NEW_LINE);
 
 Review comment:
   second append from new line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message