drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Muritiku commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on 1 Drillbit not visible on others
Date Thu, 27 Sep 2018 07:16:18 GMT
Muritiku commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on
1 Drillbit not visible on others
URL: https://github.com/apache/drill/pull/1482#discussion_r220815606
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
 ##########
 @@ -84,6 +84,7 @@
   private static final String registry_path = "registry";
   private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RemoteFunctionRegistry.class);
   private static final ObjectMapper mapper = new ObjectMapper().enable(INDENT_OUTPUT);
+  public static final int UNREACHABLE = Integer.MIN_VALUE;
 
 Review comment:
   Maybe better to use long but not int?
   Because in that case will be autoconversion in private "boolean isRegistrySyncNeeded(long
remoteVersion, long localVersion)"
   
   Just a thought. It is not reccomended in java to compare int and long directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message