drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Muritiku commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on 1 Drillbit not visible on others
Date Thu, 27 Sep 2018 07:19:09 GMT
Muritiku commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs registered on
1 Drillbit not visible on others
URL: https://github.com/apache/drill/pull/1482#discussion_r220816074
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
 ##########
 @@ -408,7 +408,7 @@ private boolean isRegistrySyncNeeded() {
    * @return true is local registry should be refreshed, false otherwise
    */
   private boolean isRegistrySyncNeeded(long remoteVersion, long localVersion) {
-    return remoteVersion != -1 && remoteVersion != localVersion;
+    return remoteVersion != RemoteFunctionRegistry.UNREACHABLE && remoteVersion !=
localVersion;
 
 Review comment:
   Look at my another comment. Here is the int to long autoconversion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message