drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to logs when error occurs during query execution
Date Thu, 27 Sep 2018 13:26:43 GMT
KazydubB commented on a change in pull request #1455: DRILL-6724: Dump operator context to
logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r220921548
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
 ##########
 @@ -47,7 +47,8 @@
   protected final boolean unionTypeEnabled;
   protected BatchState state;
 
-  // In case of Exception will be IterOutcome.STOP
+  // Used for state dump
+  protected boolean failed;
 
 Review comment:
   You're right, having one variable is sufficient. Removed unnecessary `failed` field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message